Fix tracing of recordDirtyKeys #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-Latukha
approved these changes
Dec 18, 2021
There was a problem hiding this comment.
"" argument leads to: https://hackage.haskell.org/package/opentelemetry-0.7.0/docs/src/OpenTelemetry.Eventlog_Internal.html#local-6989586621679057309
It is k there.
So it is a prefix/part of the message monoid.
There are is a minor cleaned-up detail (withEventTrace :: ... no longer needs CPP), but that is a self-solving later refactoring detail.
Seems trivial enough to be approved by me.
pepeiborra
added a commit
that referenced
this pull request
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misunderstood how
OpenTelemetry.Eventlog.addEventworks, which is not totally surprising since there are no docs.But it looks like, judging by other call sites, that the event goes in the second argument and the first argument is always "":
haskell-language-server/ghcide/src/Development/IDE/Core/Tracing.hs
Line 123 in 7794398