Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ghcide handling project root #2543

Merged
merged 5 commits into from
Jan 4, 2022

Commits on Dec 26, 2021

  1. Add new Ghcide Argument to track Project Root

    This commit provides an alternate way to grab the project root/current working directory.
    
    Prior to this commit the relative filepath "." was hard-coded for both
    Db and Custom Commands. This results in inconsistent behaviour with how
    HLS derives it's hiedb location.
    
    This new argument to the internal Ghcide Arguments, maps from the
    executable Arguments `argsCwd` or by grabbing the current working
    directory. If the user provides an option to `--cwd` we need to make
    sure we make that filepath absolute.
    
    Finally, inside the command handler, if necessary, we will grab the
    current working directory. We cannot provide a suitable default for this
    argument, therefore we leave it as a `Maybe FilePath`, even though this
    path should never be taken.
    drsooch committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    89ed1a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. Configuration menu
    Copy the full SHA
    875a1ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f8ab5fa View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Configuration menu
    Copy the full SHA
    71671f6 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Configuration menu
    Copy the full SHA
    7f8e5ed View commit details
    Browse the repository at this point in the history