Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci update hackage index #2562

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Fix ci update hackage index #2562

merged 3 commits into from
Jan 4, 2022

Conversation

jneira
Copy link
Member

@jneira jneira commented Jan 3, 2022

  • Fix freeze cache key correctly聽#2560 fixed the cabal freeze step putting cabal update before it
  • But it had a unintended effect detected in the ghc-9.2 branch: the hackage index bump done by cabal update was being overwritten by the package sources cache restoring done immediately after
  • Also reviewing ci logs i also checked the freeze file hash was not being computed. It seems the ${{ hasFiles('...') }} is resolved before the script is run 馃う

@Anton-Latukha
Copy link
Collaborator

[skip circleci]

@Anton-Latukha
Copy link
Collaborator

Please, consider hackage.yml comment before merging.

@Anton-Latukha
Copy link
Collaborator

It is also good that hackage store cache does not depend on the freeze file, so we can do this (load the source cache before determining the general cache key).

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Jan 4, 2022

Yes. It is seen in https://github.com/haskell/haskell-language-server/runs/4701985268?check_suite_focus=true that echo ::set-output name=value::${{ hashFiles('cabal.project.freeze') }} was not producing the hash:

Cache hit occurred on the primary key compiled-deps-macOS-8.10.6-2021-12-29T12-30-08Z-, not saving cache.

@Anton-Latukha Anton-Latukha added the merge me Label to trigger pull request merge label Jan 4, 2022
@mergify mergify bot merged commit a8aa016 into haskell:master Jan 4, 2022
@Anton-Latukha
Copy link
Collaborator

Nice.

@Anton-Latukha
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants