Fix hls-class-plugin on ghc-9.2 #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
July541
requested review from
jneira,
Anton-Latukha and
Ailrun
as code owners
July541
commented
Feb 22, 2022
| ( (Map.keys . Map.filter isClassNodeIdentifier . sourcedNodeIdents . sourcedNodeInfo) | ||
| <=< nodeChildren | ||
| ) | ||
| $ pointCommand hf (fromJust (fromCurrentRange pmap range) ^. J.start & J.character +~ 1) |
There was a problem hiding this comment.
In fact, this +1 is from a coincidental attempt.
|
Is this ready for review? |
Ready now! |
pepeiborra
reviewed
Feb 27, 2022
pepeiborra
reviewed
Feb 27, 2022
Comment on lines
+110
to
+119
| addWhere (InstD xInstD (ClsInstD ext decl@ClsInstDecl{..})) = | ||
| let ((EpAnn entry anns comments), key) = cid_ext | ||
| in InstD xInstD (ClsInstD ext decl { | ||
| cid_ext = (EpAnn | ||
| entry | ||
| (AddEpAnn AnnWhere (EpaDelta (SameLine 1) []) : anns) | ||
| comments | ||
| , key) | ||
| }) | ||
| addWhere decl = decl |
There was a problem hiding this comment.
can you add a brief comment explaining what this code does? It's kinda hard to read and therefore maintain
There was a problem hiding this comment.
Explained the effect of the function and the trace of the parameter.
Ailrun
reviewed
Mar 2, 2022
Ailrun
reviewed
Mar 2, 2022
|
ghc9.0 installation failed, can anyone please restart that? |
|
hls-rename-plugin failed unexpectedly |
Once more:( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me play with ghc-9.x :)