Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure for AlternateNumberFormat #2752

Merged
merged 8 commits into from Mar 7, 2022

Conversation

drsooch
Copy link
Collaborator

@drsooch drsooch commented Mar 5, 2022

This fixes alternate number format test-suite for 9.2.1 and enables it in github workflows. The plugin is already enabled in 9.2.

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! Here are some minor comments:

@michaelpj
Copy link
Collaborator

Failures on 8.8, looks like maybe this should be using some helpers from Compat?

@drsooch
Copy link
Collaborator Author

drsooch commented Mar 7, 2022

Failures on 8.8, looks like maybe this should be using some helpers from Compat?

Yeah, looks like LPat is not actually located in 8.8. Fixed.

@drsooch drsooch added the merge me Label to trigger pull request merge label Mar 7, 2022
@mergify mergify bot merged commit fbdbbd6 into haskell:master Mar 7, 2022
@drsooch drsooch deleted the fix-alternate-format-tests branch March 7, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants