Purge some more hslogger #2770
Purge some more hslogger #2770
Conversation
michaelpj
requested review from
jneira,
eddiemundo,
berberman and
pepeiborra
as code owners
michaelpj
force-pushed
the
mpj/kill-some-loggers
branch
from
4224244
to
1fbc2d8
Compare
|
@michaelpj We can purge it from hie-bios easily as well, the logic HLS uses, doesn't even use hslogger. |
At this point we only really need it for `hie-bios`.
michaelpj
force-pushed
the
mpj/kill-some-loggers
branch
from
1fbc2d8
to
9d7d6cc
Compare
| LogUsingExtensions fp exts -> "Using extensions for " <+> viaShow fp <> ":" <+> pretty exts | ||
| LogGetIdeas fp -> "Getting hlint ideas for " <+> viaShow fp |
There was a problem hiding this comment.
| LogUsingExtensions fp exts -> "Using extensions for " <+> viaShow fp <> ":" <+> pretty exts | |
| LogGetIdeas fp -> "Getting hlint ideas for " <+> viaShow fp | |
| LogUsingExtensions fp exts -> "Using extensions for" <+> viaShow fp <> ":" <+> pretty exts | |
| LogGetIdeas fp -> "Getting hlint ideas for" <+> viaShow fp |
|
I was planning to just teach |
| data Log | ||
| = LogShake Shake.Log | ||
| | LogApplying NormalizedFilePath (Either String WorkspaceEdit) | ||
| | LogGeneratedIdeas NormalizedFilePath [[Refact.Refactoring Refact.SrcSpan]] | ||
| | LogGetIdeas NormalizedFilePath | ||
| | LogUsingExtensions NormalizedFilePath [String] -- Extension is only imported conditionally, so we just stringify them |
There was a problem hiding this comment.
I think the fields should be banged, although it probably doesn't matter since our current recorders will force the fields anyway, and there are composite types that prevent some forcing, and we probably will never buildup huge thunks of NormalizedFilePath or the composite types, and I noticed I didn't bang the wrapper constructor fields everywhere anyway.
There was a problem hiding this comment.
I just added StrictData to the module, which is probably a sensible default these days anyway.
* Purge some more hslogger At this point we only really need it for `hie-bios`. * Add StrictData to Hlint plugin
At this point we only really need it for
hie-bios.