Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add associated type families to local completions #2987

Merged
merged 2 commits into from Jun 28, 2022

Conversation

gasparattila
Copy link
Contributor

@gasparattila gasparattila commented Jun 24, 2022

Currently, completing exported associated type families defined in the current module incorrectly adds an import, while non-exported ones do not show up at all. This PR fixes both of these issues.

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@pepeiborra pepeiborra enabled auto-merge (squash) June 24, 2022 18:35
@michaelpj michaelpj disabled auto-merge June 27, 2022 08:13
@michaelpj michaelpj added the merge me Label to trigger pull request merge label Jun 27, 2022
@mergify mergify bot merged commit c3c73cf into haskell:master Jun 28, 2022
hololeap pushed a commit to hololeap/haskell-language-server that referenced this pull request Aug 26, 2022
Co-authored-by: Lei Zhu <julytreee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants