Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run pre-commit hooks #3059

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Run pre-commit hooks #3059

merged 2 commits into from
Jul 28, 2022

Conversation

lunaticare
Copy link
Contributor

@lunaticare lunaticare commented Jul 24, 2022 •
edited by gitpod-io bot
Loading

I could not create a commit locally with pre-commit hook installed. Ran it locally on the clean branch:

pre-commit run --all-files

@lunaticare lunaticare marked this pull request as ready for review July 24, 2022 09:47
@lunaticare lunaticare mentioned this pull request Jul 24, 2022
Merged
Ailrun
Ailrun approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you :)

@Ailrun Ailrun enabled auto-merge (squash) July 26, 2022 07:04
auto-merge was automatically disabled July 26, 2022 21:49

Head branch was pushed to by a user without write access

@Ailrun Ailrun enabled auto-merge (squash) July 27, 2022 05:15
@Ailrun Ailrun merged commit 347a718 into haskell:master Jul 28, 2022
@lunaticare lunaticare deleted the run_precommit_hooks branch July 28, 2022 21:31
sloorush pushed a commit to sloorush/haskell-language-server that referenced this pull request Sep 12, 2022
@lunaticare @sloorush
Run pre-commit hooks (haskell#3059)
575c904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ailrun Ailrun Ailrun approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

@fendor fendor Awaiting requested review from fendor fendor is a code owner

@drsooch drsooch Awaiting requested review from drsooch drsooch is a code owner

@jneira jneira Awaiting requested review from jneira

@berberman berberman Awaiting requested review from berberman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lunaticare @Ailrun