fix lsp-types benchmark #3079
Merged
fix lsp-types benchmark #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokobd
approved these changes
Aug 7, 2022
pepeiborra
force-pushed
the
bench-lsp-typed
branch
from
b829959
to
b69909c
Compare
|
Maybe we should switch to a more stable package for benchmarking 😆 |
True, I chose |
pepeiborra
force-pushed
the
bench-lsp-typed
branch
from
525da2c
to
e000aeb
Compare
pepeiborra
requested review from
jneira,
Anton-Latukha and
Ailrun
as code owners
pepeiborra
force-pushed
the
bench-lsp-typed
branch
from
9b1e4bf
to
9b950a8
Compare
sloorush
pushed a commit
to sloorush/haskell-language-server
that referenced
this pull request
Sep 12, 2022
* fix lsp-types paths * Fail if there are no documents to benchmark * use modules with suitable positions * Fix 8.6.5 build * fix imports for 8.6.5 * Fix benchmark artifact uploads * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lsp-types benchmark definition needs some fixes in ghc 9.2
Also fixes #3102 by tar'ing the benchmark artefacts before upload