Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ghc-8.10.2 #308

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Add support for ghc-8.10.2 #308

merged 2 commits into from
Aug 11, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented Aug 10, 2020 •
edited
Loading

  • Although it seems 8.10.3 will be released soon
  • I've updated the stack-8.10.1.yaml resolver before using it as base for stack-8.10.2.yaml
  • Tested locally with cabal
  • Fixes Support for GHC-8.10.2 #298

@lukel97
Copy link
Collaborator

lukel97 commented Aug 10, 2020

Does anything need to be changed in the install script?

@jneira
Copy link
Member Author

jneira commented Aug 10, 2020

No, if you have a stack-${ghcVersion}.yaml you can build hls for that ghc version wih stack and cabal (in fact, for the latter an empty file named stack-${ghcVersion}.yaml would suffice)

@mouse07410
Copy link

mouse07410 commented Aug 11, 2020 •
edited
Loading

Although it seems 8.10.3 will be released soon

Wha...? Now they spit out a new compiler every week? :-)

@jneira do you happen to know what 8.10.3 is about? Are there some "insurmountable difficulties" or huge bugs is 8.10.2 that force 8.10.3 out? Where can I find any reference to 8.10.3? It's not in https://gitlab.haskell.org/ghc/ghc/-/tree/master

Along the same line, how difficult would it be to add 8.10.3 support? If 8.10.3 gets released to fix problems with 8.10.2, it's probably important to start supporting it ASAP?

@jneira
Copy link
Member Author

jneira commented Aug 11, 2020 •
edited
Loading

It is not usual to release versions so quickly, the main reason is https://gitlab.haskell.org/ghc/ghc/-/issues/1855.
I expect supporting 8.10.3 will be trivial, as there will be not big changes.

@lukel97 lukel97 merged commit 37c7acd into haskell:master Aug 11, 2020
@mouse07410
Copy link

... the main reason is https://gitlab.haskell.org/ghc/ghc/-/issues/1855. ...

Darn... That's a very old issue - one digit must've been lost...

I see two high-priority issues with 8.10.2:
https://gitlab.haskell.org/ghc/ghc/-/issues/18550
https://gitlab.haskell.org/ghc/ghc/-/issues/18549

It's one of these?

@jneira
Copy link
Member Author

jneira commented Aug 11, 2020

@mouse07410 ooops, yeah, i missed a digit in the copy paste, it is https://gitlab.haskell.org/ghc/ghc/-/issues/18550

@jneira jneira deleted the ghc-8.10.2 branch August 11, 2020 15:04
@jneira jneira mentioned this pull request Aug 11, 2020
Merged
pepeiborra added a commit that referenced this pull request Dec 27, 2020
@pepeiborra @aherrmann-da
Smarter logic to remove redundant import bindings (#308)
b7208a3 
* Smarter logic to remove redundant import bindings

The new code finds the spans to remove using the GHC parse tree, then manually
extends them to include commas/spaces.

Fixes #299

* Compatibility with GHC 8.4

* Improve comment

Co-Authored-By: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>

* Use breakOnEnd in unqualify

This will handle A.foo as well as A.B.foo

Co-authored-by: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukel97 lukel97 lukel97 approved these changes

@fendor fendor fendor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for GHC-8.10.2
4 participants
@jneira @lukel97 @mouse07410 @fendor