Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hls-fixity-plugin #3205

Merged
merged 2 commits into from
Oct 23, 2022
Merged

Improve hls-fixity-plugin #3205

merged 2 commits into from
Oct 23, 2022

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Sep 21, 2022

Simplify and improve the performance and memory usage behaviour or hls-fixity-plugin.

Also restore the property that hover is immediately available on startup using the cached hie file data and IdeAction mechanism.

@wz1000 wz1000 requested a review from July541 September 21, 2022 04:54
@July541
Copy link
Collaborator

July541 commented Sep 21, 2022

Many thanks for your improvement!

I'm not familiar with IdeAction, would you mind give a review? @pepeiborra

@pepeiborra
Copy link
Collaborator

Thanks. Could you also enable the benchmark for this plugin, just so we can see the improvement? Maybe the hover benchmark needs extending though..

@pepeiborra pepeiborra enabled auto-merge (squash) October 23, 2022 16:36
@pepeiborra pepeiborra merged commit 43508cd into master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants