Add suggestions about licenses in cabal file #3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, I forgot to update docs for |
fendor
force-pushed
the
cabal_licenses
branch
from
5a9da41
to
e61d328
Compare
michaelpj
reviewed
Nov 22, 2022
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/LicenseSuggest.hs
Outdated
Show resolved
Hide resolved
michaelpj
approved these changes
Nov 23, 2022
|
Still lacks some redesign of the tests, will get to it, maybe next weekend. |
|
Sorry, not clear if that means you want to merge it or not? Also should maybe have some feature doc? |
|
CI is red, it can't be merged outright, no? And the CI is red because the test-suite fails because it suggests more than previously expected. |
|
Ah I see, I'll let you deal with it then :) |
|
CI is probably green now, ready for final review, I think. |
michaelpj
requested changes
Nov 24, 2022
fendor
force-pushed
the
cabal_licenses
branch
from
a291ac4
to
0cde028
Compare
fendor
reviewed
Nov 24, 2022
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/LicenseSuggest.hs
Outdated
Show resolved
Hide resolved
michaelpj
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends very much on #2954
Old approach depends on error message from cabal. So it was only capable of suggetsions on input
BSD2andBSD3.This approach uses license list from
cabal-syntaxpackage, but still depends on error message from cabal (though it extracts only original name, and uses that to find similar one in supported list)