Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various PluginError PR suggestions I missed earlier #3737

Merged
merged 34 commits into from
Jul 31, 2023
Merged

Various PluginError PR suggestions I missed earlier #3737

merged 34 commits into from
Jul 31, 2023

Commits on Jun 19, 2023

  1. WIP

    @fendor
    fendor committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    8adb03e View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Merge fendor/enhance/plugin-logger-structure 

    Merge fendor/enhance/plugin-logger-structure
    @joyfulmantis
    joyfulmantis committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    4e65cbe View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Make compilable

    @joyfulmantis
    joyfulmantis committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    d4a9d4e View commit details
    Browse the repository at this point in the history

  2. merge upstream/master

    @joyfulmantis
    joyfulmantis committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    e1b62cb View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Flatten error hierarchy and avoid name clashes

    @joyfulmantis
    joyfulmantis committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e34da52 View commit details
    Browse the repository at this point in the history

  2. merge upstream/master

    @joyfulmantis
    joyfulmantis committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    ca81317 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Replace ResponseError with PluginError for plugins 

    Additionally further PluginError constructors and helpers refactoring
    @joyfulmantis
    joyfulmantis committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    1776bd8 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Further support for PluginError in HLS.hs among other enhancements

    @joyfulmantis
    joyfulmantis committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    bc093c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. Further improvements

    @joyfulmantis
    joyfulmantis committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    9bc837a View commit details
    Browse the repository at this point in the history

  2. Fix code-range test

    @joyfulmantis
    joyfulmantis committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    40d589c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into plugin-logger

    @joyfulmantis
    joyfulmantis committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    fd11649 View commit details
    Browse the repository at this point in the history

  4. Fix build error

    @joyfulmantis
    joyfulmantis committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    15cf638 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Added note

    @joyfulmantis
    joyfulmantis committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    cdc0364 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. merge upstream/master

    @joyfulmantis
    joyfulmantis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d78f2bc View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. address michaelpj's suggestions (1/n)

    @joyfulmantis
    joyfulmantis committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    9b539d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. more improvements

    @joyfulmantis
    joyfulmantis committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d415379 View commit details
    Browse the repository at this point in the history

  2. window build fix attempt

    @joyfulmantis
    joyfulmantis committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    e618d7e View commit details
    Browse the repository at this point in the history

  3. Fix stack and windows builds

    @joyfulmantis
    joyfulmantis committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    6fee73f View commit details
    Browse the repository at this point in the history

  4. Fix code-range test

    @joyfulmantis
    joyfulmantis committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    6cbe6d9 View commit details
    Browse the repository at this point in the history

  5. refactor splice and eval to remove underscore func

    @joyfulmantis
    joyfulmantis committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    e0bbec1 View commit details
    Browse the repository at this point in the history

  6. Fix hls-tactics-plugin test

    @joyfulmantis
    joyfulmantis committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    6102e6b View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Broke up the ghcide test file

    @joyfulmantis
    joyfulmantis committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    953003a View commit details
    Browse the repository at this point in the history

  2. have CommandFunction use ExceptT

    @joyfulmantis
    joyfulmantis committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    9bbf421 View commit details
    Browse the repository at this point in the history

  3. add tests for exceptions and PluginError order

    @joyfulmantis
    joyfulmantis committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    afcf19d View commit details
    Browse the repository at this point in the history

  4. fix tactics build

    @joyfulmantis
    joyfulmantis committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    77d264f View commit details
    Browse the repository at this point in the history

  5. fix tactics try 2

    @joyfulmantis
    joyfulmantis committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    1a22bcc View commit details
    Browse the repository at this point in the history

  6. fix tactics build try 3

    @joyfulmantis
    joyfulmantis committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    28bdecc View commit details
    Browse the repository at this point in the history

  7. fix for real this time

    @joyfulmantis
    joyfulmantis committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    1dd12d4 View commit details
    Browse the repository at this point in the history

  8. Fix hlint rules

    @joyfulmantis
    joyfulmantis committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    ba4fa79 View commit details
    Browse the repository at this point in the history

  9. hlint rule fixes try 2

    @joyfulmantis
    joyfulmantis committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    89bba81 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Merge remote-tracking branch 'upstream/master' into plugin-logger

    @joyfulmantis
    joyfulmantis committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    82e3ff5 View commit details
    Browse the repository at this point in the history

  2. address michealpj's suggestions

    @joyfulmantis
    joyfulmantis committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a215904 View commit details
    Browse the repository at this point in the history

  3. Add haddocks

    @joyfulmantis
    joyfulmantis committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    f15ea45 View commit details
    Browse the repository at this point in the history

  4. Update HLS.hs

    @joyfulmantis
    joyfulmantis committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    8329b90 View commit details
    Browse the repository at this point in the history