Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Fourmolu 0.14.0.0 #3796

Merged
merged 5 commits into from
Sep 10, 2023

Conversation

brandonchinn178
Copy link
Contributor

@brandonchinn178 brandonchinn178 commented Sep 7, 2023

This was just released: https://github.com/fourmolu/fourmolu/releases/tag/v0.14.0.0

Also includes some minor refactoring. I think it should be pretty uncontroversial, but if not, I can break out into a separate PR

Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@michaelpj
Copy link
Collaborator

You need to bump the index-state in cabal.project. I'm curious, did this build locally for you?

@brandonchinn178
Copy link
Contributor Author

You need to bump the index-state in cabal.project. I'm curious, did this build locally for you?

Nope 😄 Just pushed without testing. Sorry, just tested and it should work now

@michaelpj
Copy link
Collaborator

I wondered but I didn't think you could have done the refactoring like that 😂

@brandonchinn178
Copy link
Contributor Author

Just made good guesses in the refactor? 😂

Anyway, the test failures are unrelated. The Nix failure does seem relevant

       > Setup: Encountered missing or private dependencies:
       > fourmolu >=0.14 && <0.15

but I'm not sure how to update the Nix files

@July541
Copy link
Collaborator

July541 commented Sep 9, 2023

I'm thinking is it possible to separate nix stuffs from the hls repo🤔️

@michaelpj michaelpj merged commit e6ac381 into haskell:master Sep 10, 2023
38 of 42 checks passed
@michaelpj
Copy link
Collaborator

That's why the check is not required :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants