Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golden tests for public configs #3922

Merged
merged 2 commits into from
Jan 4, 2024

Commits on Jan 2, 2024

  1. Add golden tests for public configs

    Changes to the vscode schema need to be communicated to vscode-haskell plugin maintainers,
    otherwise users can't make use of the new configurations.
    
    In general, changes to the schema need to be done consciously when new plugin or features are added.
    We add these golden tests as an additional contract to inform relevant
    parties whenever the configs change.
    
    To fix a failing of these tests, review the change. If it is expected, accept the change via:
    
        TASTY_PATTERN="generate schema" cabal test func-test --test-options=--accept
    
    As changes need to be applied for all GHC version specific configs, you either need to run this command for each
    GHC version that is affected by the config change, or manually add the change to all other golden config files.
    Likely, the easiest way is to run CI and apply the generated diffs manually.
    fendor committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    eb2a0a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Configuration menu
    Copy the full SHA
    4a5c923 View commit details
    Browse the repository at this point in the history