update Floskell to 0.11.*

[peterbecich]

Closes: #3927

hls-floskell-plugin updated to floskell 0.11.* . The reason is that floskell 0.11.* supports aeson 2.2.* : https://hackage.haskell.org/package/floskell-0.11.0

There is a small change required in plugins/hls-floskell-plugin/src/Ide/Plugin/Floskell.hs. The easy change breaks compatibility with floskell 0.10. So I have bumped the version of hls-floskell-plugin from 2.5.0.0 to 2.5.1.0.

haskell-language-server 2.5.0.0 is pinned to hls-floskell-plugin 2.5.0.0 exactly. This PR changes the bound on hls-floskell-plugin to 2.5.*.

• This could be a revision to haskell-language-server 2.5.0.0
• or a fix version, haskell-language-server 2.5.0.1.
  • I believe haskell-language-server 2.5.0.1 is compatible with both:
    • hls-floskell-plugin 2.5.0.0 and floskell 0.10.*
      • first test
    • hls-floskell-plugin 2.5.1.0 and floskell 0.11.*
      • second test

What do you think?

I suppose this PR should target the tag 2.5.0.0 https://github.com/haskell/haskell-language-server/tree/2.5.0.0 instead of master

---

First test
git reset to master. Apply only the change to haskell-language-server.cabal. Build haskell-language-server 2.5.0.1 and all other packages.

This builds successfully:

cabal build --constraint 'floskell == 0.10.*' --enable-tests

Second test
In this PR, this builds successfully:

cabal build --constraint 'floskell == 0.11.*' --enable-tests

These tests were run in the nix develop shell.

[fendor]

LGTM, just dont do the the version bumps :)

[fendor]

HLS and all its plugins use lockstep versioning. Thus, all versions get universally bumped on release and you shouldn't bump versions in PRs, as this throws off our automation.
Just keep it at 2.5.0.0 :)

[fendor]

Just keep it as 2.5.0.0 :)

[michaelpj]

The stack.yamls need to be adjusted to pull in the newer floskell.

Please also add yourself to CODEOWNERS, thanks!

[peterbecich]

Thanks @fendor and @michaelpj

Can we squash and cherry-pick this onto https://github.com/haskell/haskell-language-server/tree/2.5.0.0 and release a revision of haskell-language-server 2.5.0.0? Or will it wait until 2.6.0.0 to go out?

---

stack.yaml build succeeds

stack build hls-floskell-plugin

Looking at lts-21 now

stack build --stack-yaml stack-lts21.yaml hls-floskell-plugin

[michaelpj]

We're not generally doing backports, so it'll just be in the next release. That will probably be soon, since there's a GHC release coming.

[peterbecich]

this succeeds:

stack build --stack-yaml stack-lts21.yaml 

[michaelpj]

Great stuff, thanks!