Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to hiedb 0.5.0.0 to fix #3542 #3943

Merged
merged 2 commits into from Jan 13, 2024
Merged

Bump to hiedb 0.5.0.0 to fix #3542 #3943

merged 2 commits into from Jan 13, 2024

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Jan 12, 2024

No description provided.

@michaelpj
Copy link
Collaborator

Looks like genuine build failures though.

@wz1000 wz1000 requested a review from July541 as a code owner January 12, 2024 11:21
@michaelpj
Copy link
Collaborator

Stuff seems quite broken.

@konn konn mentioned this pull request Jan 13, 2024
Closed
@peterbecich
Copy link
Member

peterbecich commented Jan 13, 2024 •
edited

closes: #3945

@peterbecich
Copy link
Member

I see this requires hiedb 0.5.0.1

NixPkgs haskell-updates is still on 0.5.0.0

$ nix search nixpkgs/haskell-updates#haskellPackages hiedb
* legacyPackages.x86_64-linux.haskellPackages.hiedb (0.5.0.0)
  Generates a references DB from .hie files

is that an issue?

@peterbecich peterbecich linked an issue Jan 13, 2024 that may be closed by this pull request
support for hiedb 0.5.* in ghcide #3945
Closed
@michaelpj
Copy link
Collaborator

HLS master is often on the bleeding edge of hackage, so yeah, we're going to be ahead.

@michaelpj
Copy link
Collaborator

Index state bump was maybe not enough? Cabal isn't finding the new version

@wz1000
Copy link
Collaborator Author

wz1000 commented Jan 13, 2024

I think some jobs just started too early to pick up the hackage update.

@wz1000 wz1000 enabled auto-merge (rebase) January 13, 2024 12:18
@wz1000 wz1000 merged commit 4ae63f0 into master Jan 13, 2024
41 checks passed
@chenrui333 chenrui333 mentioned this pull request Jan 17, 2024
Merged
@wz1000 wz1000 mentioned this pull request Jan 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

@July541 July541 Awaiting requested review from July541 July541 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for hiedb 0.5.* in ghcide
3 participants
@wz1000 @michaelpj @peterbecich