Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup conditional build logic pertaining to pre 9.2 GHCs #3948

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Cleanup conditional build logic pertaining to pre 9.2 GHCs #3948

merged 4 commits into from
Jan 16, 2024

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Jan 13, 2024

Since we're supporting GHCs 9.2+ we can assume that impl(ghc >= 9.2) will be true going forward.

@jhrcek jhrcek changed the title Remove conditional cabal logic pertaining to pre 9.2 GHCs Cleanup conditional cabal logic pertaining to pre 9.2 GHCs Jan 13, 2024
@jhrcek jhrcek changed the title Cleanup conditional cabal logic pertaining to pre 9.2 GHCs Cleanup conditional build logic pertaining to pre 9.2 GHCs Jan 13, 2024
fendor
fendor requested changes Jan 13, 2024
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup! Just some comments or nitpicks

ghcide/ghcide.cabal Show resolved Hide resolved
ghcide/ghcide.cabal Outdated Show resolved Hide resolved
plugins/hls-fourmolu-plugin/hls-fourmolu-plugin.cabal Outdated Show resolved Hide resolved
@jhrcek jhrcek requested a review from fendor January 13, 2024 15:16
michaelpj
michaelpj reviewed Jan 13, 2024
View reviewed changes
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

plugins/hls-fourmolu-plugin/hls-fourmolu-plugin.cabal Outdated Show resolved Hide resolved
fendor
fendor approved these changes Jan 14, 2024
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@michaelpj michaelpj enabled auto-merge (squash) January 14, 2024 09:12
@michaelpj michaelpj added the merge me Label to trigger pull request merge label Jan 14, 2024
auto-merge was automatically disabled January 16, 2024 05:05

Head branch was pushed to by a user without write access

@jhrcek jhrcek force-pushed the jhrcek/cleanup-cabal-conditionals branch from 83efba1 to 4430fc7 Compare January 16, 2024 05:05
@jhrcek
Copy link
Collaborator Author

jhrcek commented Jan 16, 2024

Rebased on master

@mergify mergify bot merged commit 4b491c2 into haskell:master Jan 16, 2024
42 checks passed
@jhrcek jhrcek deleted the jhrcek/cleanup-cabal-conditionals branch January 19, 2024 04:14
josephsumabat pushed a commit to josephsumabat/haskell-language-server that referenced this pull request Jan 22, 2024
@jhrcek @josephsumabat
Cleanup conditional build logic pertaining to pre 9.2 GHCs (haskell#3948
298affb 
)

* Remove conditional cabal logic pertaining to no-longer supported (pre 9.2) GHCs

* Cleanup in github workflows

* Apply review suggestions

* Remove unnecessary fourmolu constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj left review comments

@fendor fendor fendor approved these changes

@joyfulmantis joyfulmantis Awaiting requested review from joyfulmantis joyfulmantis is a code owner

@georgefst georgefst Awaiting requested review from georgefst georgefst is a code owner

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 is a code owner

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhrcek @michaelpj @fendor