Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic tokens: expand type synonym to checkout forall function type when possible #3967

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Semantic tokens: expand type synonym to checkout forall function type when possible #3967

merged 5 commits into from
Jan 16, 2024

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Jan 16, 2024 •
edited
Loading

should fix #3966

  1. Add test for function type under type synonym
  2. Expand type synoym for type from the in memory hieAst to extract function mask.

Forall function under type syn is checked out now.
image

@soulomoon soulomoon changed the title expand type synonym to extract function type when possible Semantic tokens: expand type synonym to extract function type when possible Jan 16, 2024
@soulomoon soulomoon self-assigned this Jan 16, 2024
@soulomoon soulomoon changed the title Semantic tokens: expand type synonym to extract function type when possible Semantic tokens: expand type synonym to checkout function type when possible Jan 16, 2024
@soulomoon soulomoon changed the title Semantic tokens: expand type synonym to checkout function type when possible Semantic tokens: expand type synonym to checkout forall function type when possible Jan 16, 2024
@soulomoon
mend
9cfeefe 
rename coreFullView to avoid conliction in ghc 9.8
@soulomoon
mend
1670e0d 
cleanup
@soulomoon soulomoon marked this pull request as ready for review January 16, 2024 10:34
@soulomoon soulomoon enabled auto-merge (squash) January 16, 2024 10:34
@soulomoon soulomoon added the merge me Label to trigger pull request merge label Jan 16, 2024
wz1000
wz1000 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@wz1000 wz1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me.

@soulomoon soulomoon merged commit 8697f5f into haskell:master Jan 16, 2024
40 checks passed
@soulomoon
Copy link
Collaborator Author

looks reasonable to me.

Thanx for the review

@soulomoon soulomoon deleted the expand-type-synonym-for-function-judge-semantic-tokens branch January 16, 2024 15:48
@soulomoon soulomoon restored the expand-type-synonym-for-function-judge-semantic-tokens branch January 16, 2024 15:48
@soulomoon soulomoon deleted the expand-type-synonym-for-function-judge-semantic-tokens branch January 16, 2024 15:59
josephsumabat pushed a commit to josephsumabat/haskell-language-server that referenced this pull request Jan 22, 2024
@soulomoon @josephsumabat
Semantic tokens: expand type synonym to checkout forall function type…
6e10006 
… when possible (haskell#3967)

* expand type synonym to extract function type when possible

* rename coreFullView to avoid conliction in ghc 9.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wz1000 wz1000 wz1000 approved these changes

Assignees

@soulomoon soulomoon

Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semantic tokens forall function hide under type syn is not recognized
2 participants
@soulomoon @wz1000