Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support tables #3987

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Update support tables #3987

merged 2 commits into from
Jan 20, 2024

Conversation

michaelpj
Copy link
Collaborator

Now @wz1000 has fixed the exactprint plugins I think we can declare full support for 9.8.

Now @wz1000 has fixed the exactprint plugins I think we can declare full
support for 9.8.
@michaelpj michaelpj requested a review from fendor January 19, 2024 11:17
@wz1000
Copy link
Collaborator

wz1000 commented Jan 19, 2024

If this is rendered on to the readthedocs website immediately it might be confusing for users of 2.6.0.0 that exactprint plugins aren't available on their HLS.

@michaelpj
Copy link
Collaborator Author

We've always had this problem. If we actually care we need to do per-version docs on RTD, which we can do, but is just More Work. If we wait until the next release we probably won't remember 🤷

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks good to me!

However, the docs are truly incorrect, as the latest release does not have support for 9.8.1.

We should version the docs, but the additional work seems almost not worth it.

I think we should keep this PR open as a reminder, but not merge quite yet.

@michaelpj
Copy link
Collaborator Author

I made versioned docs work

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Jan 20, 2024
@michaelpj michaelpj merged commit 98efc37 into master Jan 20, 2024
38 of 40 checks passed
josephsumabat pushed a commit to josephsumabat/haskell-language-server that referenced this pull request Jan 22, 2024
Now @wz1000 has fixed the exactprint plugins I think we can declare full
support for 9.8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants