Bump lsp versions #4052
Merged
Bump lsp versions #4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
requested review from
konn,
soulomoon,
pepeiborra,
santiweight,
eddiemundo,
georgefst,
July541,
peterbecich,
fendor and
VeryMilkyJoe
as code owners
michaelpj
commented
Feb 5, 2024
| @@ -207,7 +209,7 @@ splitAtPosition pos ls = do | |||
| split <- splitFile | |||
| pure $ reverse $ Rope.lines $ fst split | |||
| where | |||
| splitFile = Rope.splitAtPosition ropePos ls | |||
| splitFile = Rope.utf16SplitAtPosition ropePos ls | |||
There was a problem hiding this comment.
I think I set this up right, but I'm not 100% sure. We would need a cabal file test with unicode characters...
|
I also haven't taken advantage of the fact that we now get an updater that lets us send text-only updates from |
michaelpj
force-pushed
the
mpj/lsp-bump
branch
from
30f7e40
to
0cb5bf9
Compare
wz1000
reviewed
Feb 8, 2024
| @@ -28,6 +28,7 @@ tests = testGroup "watched files" | |||
| [ testSession' "workspace files" $ \sessionDir -> do | |||
| liftIO $ writeFile (sessionDir </> "hie.yaml") "cradle: {direct: {arguments: [\"-isrc\", \"A\", \"WatchedFilesMissingModule\"]}}" | |||
| _doc <- createDoc "A.hs" "haskell" "{-#LANGUAGE NoImplicitPrelude #-}\nmodule A where\nimport WatchedFilesMissingModule" | |||
| setIgnoringRegistrationRequests False | |||
There was a problem hiding this comment.
It says "don't pretend that registerCapability and unregisterCapability messages don't exist", which we mostly want to otherwise it adds more noise. This test actually looks at those messages so needs to set this.
michaelpj
force-pushed
the
mpj/lsp-bump
branch
from
8e05104
to
6d01077
Compare
Broadly:
- A few places where we need to pipe `ProgressToken`s around.
- I also just removed the progress reporting from resolve commands,
since it's going to often be costly to do progress reporting on
something that short. Possibly we could revisit after haskell/lsp#549
- Some changes to the registration options we infer
- A few places where we need to adapt to ignoring registrations or not
- Adapting to use the ghcide verison of `getCompletionPrefix` everywhere
- Adapting to use the new mixed rope format
michaelpj
force-pushed
the
mpj/lsp-bump
branch
from
6d01077
to
f59d4e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broadly:
ProgressTokens around.getCompletionPrefixeverywhere