Enable pedantic for more components #4061
Conversation
| @@ -72,5 +72,3 @@ if impl(ghc >= 9.7) | |||
| -- this is okay | |||
| allow-newer: | |||
| ekg-core:text, | |||
| -- https://github.com/haskell-primitive/primitive-unlifted/issues/39 | |||
| primitive-unlifted:bytestring, | |||
There was a problem hiding this comment.
Seems like primitive-unlifted is not used by anything anymore, so removing it from here.
There was a problem hiding this comment.
It's a transitive dependency, but if it works then it works!
| indirectOldNames <- concat . filter ((>1) . Prelude.length) <$> | ||
| mapM (uncurry (getNamesAtPos state) . locToFilePos) directRefs | ||
| indirectOldNames <- concat . filter notNull <$> | ||
| mapM (uncurry (getNamesAtPos state)) (mapMaybe locToFilePos directRefs) |
There was a problem hiding this comment.
Changed locToFilePos (see definition below) to return Maybe.
I hope that silently ignoring paths for which uriToNormalizedFilePath returns Nothing, rather than crashing is ok.
There was a problem hiding this comment.
Hmm, I think we might want to fail the rename, because that means there's a potential reference that we couldn't resolve, so we might not be doing a correct rename.
There was a problem hiding this comment.
Maybe just add a comment at least.
There was a problem hiding this comment.
Ok, will dive a bit into how this works and get back to this.
There was a problem hiding this comment.
Ok, I found there's a dedicated getNormalizedFilePathE that does Uri -> NormalizeFilePath translation and throws PluginError when this fails. I switched to using that because it sounds cleaner/more informative than pattern match error..
jhrcek
requested review from
michaelpj,
pepeiborra,
eddiemundo,
July541 and
fendor
as code owners
| indirectOldNames <- concat . filter ((>1) . Prelude.length) <$> | ||
| mapM (uncurry (getNamesAtPos state) . locToFilePos) directRefs | ||
| indirectOldNames <- concat . filter notNull <$> | ||
| mapM (uncurry (getNamesAtPos state)) (mapMaybe locToFilePos directRefs) |
There was a problem hiding this comment.
Hmm, I think we might want to fail the rename, because that means there's a potential reference that we couldn't resolve, so we might not be doing a correct rename.
| indirectOldNames <- concat . filter ((>1) . Prelude.length) <$> | ||
| mapM (uncurry (getNamesAtPos state) . locToFilePos) directRefs | ||
| indirectOldNames <- concat . filter notNull <$> | ||
| mapM (uncurry (getNamesAtPos state)) (mapMaybe locToFilePos directRefs) |
There was a problem hiding this comment.
Maybe just add a comment at least.
jhrcek
force-pushed
the
jhrcek/more-pedantic
branch
from
cbfe71a
to
1391769
Compare
No description provided.