Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more workarounds for GHCs < 9.2 (#4092) #4098

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Feb 27, 2024

Further cleanups based on the fact that we can assume ghcVersion >= GHC92

@@ -1,6 +0,0 @@
{-# LANGUAGE DuplicateRecordFields, TypeApplications, TypeFamilies, UndecidableInstances, FlexibleContexts, DataKinds, MultiParamTypeClasses, TypeSynonymInstances, FlexibleInstances #-}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this because one of the tests being removed says
ignoreForGHC92Plus "No need for this plugin anymore!"

@jhrcek jhrcek marked this pull request as ready for review February 27, 2024 20:02
@jhrcek jhrcek requested a review from fendor February 28, 2024 04:37
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@michaelpj michaelpj merged commit 41de40e into haskell:master Feb 28, 2024
39 checks passed
@jhrcek jhrcek deleted the jhrcek/remove-pre-9.2-workarounds branch March 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants