Exit with non-zero exitcode if wrapper fails to launch #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
requested review from
hasufell and
michaelpj
and removed request for
michaelpj
|
I can't really judge whether this is correct. Have you tested it? |
|
I have tested the Wrapper change locally. On 2.6.0.0, when the wrapper runs |
hasufell
approved these changes
Mar 2, 2024
Only when in LSP mode, we want to launch the LSP server that offers the restart capability.
fendor
force-pushed
the
fix/wrapper-exitcode
branch
from
1d9a130
to
ab159c0
Compare
michaelpj
approved these changes
Mar 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by #3748 (comment), the tests are not run correctly, since there is no GHC installed. We install the recommended GHC version to make sure one (hopefully) supported GHC version is installed for running the wrapper test.
Further, if setup fails, HLS-wrapper launches an LSP server that allows users to restart the server once they have fixed potential setup issues. That's only desired if we are indeed launching as an LSP server. Thus, we exit with a non-zero exit code if setup fails and we are not launching in LSP mode.