Drop Legacy Logger from Codebase #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
enhance/drop-logger-from-shakeextras
branch
from
fb0bfe5
to
d8380bd
Compare
jhrcek
reviewed
Apr 12, 2024
jhrcek
reviewed
Apr 12, 2024
jhrcek
reviewed
Apr 12, 2024
fendor
force-pushed
the
enhance/drop-logger-from-shakeextras
branch
2 times, most recently
from
0e7e71c
to
552885a
Compare
|
I am pretty sure I broke opentelemetry support, so I have yet to fix that :) |
fendor
force-pushed
the
enhance/drop-logger-from-shakeextras
branch
3 times, most recently
from
427d38f
to
bfd4629
Compare
|
I think I fixed the opentelemetry stuff, hopefully only minor mistakes. @soulomoon assured me, we can check that opentelemetry still works as expected by looking at the benchmarks :) So, we still have to check the benchmarks and report the results here. |
michaelpj
approved these changes
Apr 15, 2024
fendor
force-pushed
the
enhance/drop-logger-from-shakeextras
branch
2 times, most recently
from
1515483
to
5bc9fd4
Compare
|
Nothing escapes your eagle-eyed review 😅 Thanks, should be all updated now. |
Move ghcide completely to colog-logging style. Move plugins that were relying on `ideLogger` to colog style logging. Move opentelemetry to colog-logging style. This allows us to drop legacy code and unify the logging experience in HLS. We add a bunch of new Log constructors at various locations that aim to be identical to their previous `Logger` statements.
fendor
force-pushed
the
enhance/drop-logger-from-shakeextras
branch
from
5bc9fd4
to
5bc5251
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ghcide completely to colog-logging style.
Move plugins that were relying on
ideLoggerto colog style logging.Move opentelemetry to colog-logging style.
This allows us to drop legacy code and unify the logging experience in
HLS.
We add a bunch of new Log constructors at various locations that aim to
be identical to their previous
Loggerstatements.Just a bit of busy work. It started out as migrating
ekgto colog style logging.Now only the telemetry logger usesFixed.Logger.