Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migrate DependentFileTest] part of #4173 Migrate ghcide tests to hls test utils #4195

Conversation

soulomoon
Copy link
Collaborator

part of #4173
This is specially flalky see #4194

Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just remember to remove the traces before merging!

@soulomoon
Copy link
Collaborator Author

thanks for the review, will do it soon!

@soulomoon soulomoon changed the title [Migrate CompletionTests] part of #4173 Migrate ghcide tests to hls test utils [Migrate DependentFileTest] part of #4173 Migrate ghcide tests to hls test utils Apr 29, 2024
@soulomoon soulomoon marked this pull request as ready for review April 29, 2024 12:41
@michaelpj michaelpj enabled auto-merge (squash) April 29, 2024 14:15
@michaelpj michaelpj merged commit a3e4b95 into haskell:master Apr 29, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants