Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support structured diagnostics #4311

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Support structured diagnostics #4311

wants to merge 42 commits into from

Commits on Jun 10, 2024

  1. Change FileDiagnostic type synonym to a datatype

    @dylan-thinnes
    dylan-thinnes committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d5b70e0 View commit details
    Browse the repository at this point in the history

  2. Make ideErrorWithSource produce FileDiagnostic by adding filepath arg

    @dylan-thinnes
    dylan-thinnes committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    3c9ae07 View commit details
    Browse the repository at this point in the history

  3. Supply structured error wherever we easily can - TODOs for hard parts 

    We're leaving the TODOs for either later in this PR or in another PR
    @dylan-thinnes
    dylan-thinnes committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ac78312 View commit details
    Browse the repository at this point in the history

  4. Fix UnitTests for new FileDiagnostic struct

    @dylan-thinnes
    dylan-thinnes committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4b39d0f View commit details
    Browse the repository at this point in the history

  5. Remove explicit uses of FileDiagnostic, add codes to LSP diagnostics

    @dylan-thinnes
    dylan-thinnes committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    465ee2b View commit details
    Browse the repository at this point in the history

  6. Add field for expected error codes in ghcide tests

    @dylan-thinnes
    dylan-thinnes committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4d2f3f0 View commit details
    Browse the repository at this point in the history

  7. Expect GHC-83865 for "type error" test - basic test

    @dylan-thinnes
    dylan-thinnes committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e4ca141 View commit details
    Browse the repository at this point in the history

  8. Return structured warnings in TcModuleResult by copying from Driver

    @dylan-thinnes
    dylan-thinnes committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    2a2bc3d View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Store FileDiagnostic instead of LSP Diagnostic in Shake store

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    2cd33df View commit details
    Browse the repository at this point in the history

  2. Add expected error codes for diagnostics that have them

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    c4d5edd View commit details
    Browse the repository at this point in the history

  3. Dispatch TODOs, amend remaining TODOs as future work

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    ae50843 View commit details
    Browse the repository at this point in the history

  4. Add scary comments all over copied code in Compat.Driver

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    0cf77e5 View commit details
    Browse the repository at this point in the history

  5. Update all remaining diagnostics that could use an expected error code

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    4b452c9 View commit details
    Browse the repository at this point in the history

  6. Add _code to pretty printing for FileDiagnostic

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    25b02fa View commit details
    Browse the repository at this point in the history

  7. Use case instead of maybe for StructuredMessage match

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    a46f0a2 View commit details
    Browse the repository at this point in the history

  8. Use CPP to prevent setting _code before structured errors

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    25bfcb3 View commit details
    Browse the repository at this point in the history

  9. Swap modifier for lenses, document StructuredMessage type

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    003c15c View commit details
    Browse the repository at this point in the history

  10. Add link to Issue & MR to Compat.Driver

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    3500ac3 View commit details
    Browse the repository at this point in the history

  11. Drop attachReason logic from withWarnings, technically incorrect

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    4fed987 View commit details
    Browse the repository at this point in the history

  12. Revert "Drop attachReason logic", needed by pragmas-plugin 

    This reverts commit 4fed987.
    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    74b245d View commit details
    Browse the repository at this point in the history

  13. Fix plugins where necessary for new diagnostic structure

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    326f314 View commit details
    Browse the repository at this point in the history

  14. Fix build issues with other tests from expectDiagnostics

    @dylan-thinnes
    dylan-thinnes committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    52150c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Improve comment on metadata fdStructuredMessage in FileDiagnostic

    @dylan-thinnes
    dylan-thinnes committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7ec0481 View commit details
    Browse the repository at this point in the history

  2. Add note to withWarnings explaining the current state of things

    @dylan-thinnes
    dylan-thinnes committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    be37756 View commit details
    Browse the repository at this point in the history

  3. Attach reasons into data field of LSP Diagnostic instead of code field 

    Had to move `attachReason` between modules to achieve this, which is
fine because it was never exported from its own module.
    @dylan-thinnes
    dylan-thinnes committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7bb82d0 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into support-structure… 

    …d-diagnostics
    @dylan-thinnes
    dylan-thinnes committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    c248bb3 View commit details
    Browse the repository at this point in the history

  5. Fix up mistakes from merge, TODO fix merge issues for 9.3.0

    @dylan-thinnes
    dylan-thinnes committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8d310fb View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Set CodeDescription from HaskellErrorIndex when available

    @dylan-thinnes
    dylan-thinnes committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    414c845 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Remove debugging print, fix expectation for preprocessor tests

    @dylan-thinnes
    dylan-thinnes committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    fc22ac5 View commit details
    Browse the repository at this point in the history

  2. Fix CPP for using Show instance on DiagnosticCode

    @dylan-thinnes
    dylan-thinnes committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5bb39cd View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Remove diagFromErrMsgs for GHC version < 9.6.1 using CPP

    @dylan-thinnes
    dylan-thinnes committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    8051130 View commit details
    Browse the repository at this point in the history

  2. CPP fix

    @dylan-thinnes
    dylan-thinnes committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0e9d75e View commit details
    Browse the repository at this point in the history

  3. More stylish-haskell, more CPP fix

    @dylan-thinnes
    dylan-thinnes committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    863e42e View commit details
    Browse the repository at this point in the history

  4. Fix all stylish-haskell errors triggering

    @dylan-thinnes
    dylan-thinnes committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    4c798e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Fix more CPP

    @dylan-thinnes
    dylan-thinnes committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    b7761de View commit details
    Browse the repository at this point in the history

  2. Only override the LSP diagnostic code when not already set

    @dylan-thinnes
    dylan-thinnes committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    596a4cb View commit details
    Browse the repository at this point in the history

  3. Fixes for stylish-haskell 

    stylish-haskell does not handle CPP pragmas very well, is this a
regression?
    @dylan-thinnes
    dylan-thinnes committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    58cdc41 View commit details
    Browse the repository at this point in the history

  4. Qualify s, t for FuzzySearch

    @dylan-thinnes
    dylan-thinnes committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    503a861 View commit details
    Browse the repository at this point in the history

  5. Ignore use of unsafePerformIO in FuzzySearch

    @dylan-thinnes
    dylan-thinnes committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    3ad6bca View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Properly split GHC.Types.Error import in Diagnostics for stylish-haskell

    @dylan-thinnes
    dylan-thinnes committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    c30267c View commit details
    Browse the repository at this point in the history

  2. Force type signature of annotation on FuzzySearch.dictionary

    @dylan-thinnes
    dylan-thinnes committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    29133ba View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. DRY up definition of closure_errs 

    From review haskell#4311 (comment)
    @dylan-thinnes
    dylan-thinnes committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    1a76f88 View commit details
    Browse the repository at this point in the history