Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal fix for eval regression #488

Merged
merged 3 commits into from
Oct 11, 2020

Conversation

pepeiborra
Copy link
Collaborator

Minimal fix for the regression raised in #483 and #485
This is a serious regression which would justify a minor release.

@jneira
Copy link
Member

jneira commented Oct 10, 2020

Thanks for the quick fix

@mpickering
Copy link
Contributor

I suppose this was the issue which was causing the plugin to fail when I tried it. Thanks Pepe.

@lukel97
Copy link
Collaborator

lukel97 commented Oct 11, 2020

@pepeiborra shall I prepare 0.5.1 once this is merged?

@pepeiborra
Copy link
Collaborator Author

@pepeiborra shall I prepare 0.5.1 once this is merged?

I guess it depends on how much work is required. If it's non trivial then it would make sense to wait and collect any other fixes needed.

@lukel97
Copy link
Collaborator

lukel97 commented Oct 11, 2020

@pepeiborra should just be a matter of bumping the .cabal file, tagging and making a GitHub release, so not much effort at all. We can wait a couple days to see if there's any other bug fix PRs coming in

@pepeiborra
Copy link
Collaborator Author

@pepeiborra should just be a matter of bumping the .cabal file, tagging and making a GitHub release, so not much effort at all. We can wait a couple days to see if there's any other bug fix PRs coming in

If it's that easy, do go for it! I'll get this merged today.

@pepeiborra pepeiborra merged commit 5a51fbd into haskell:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eval Plugin can't handle local module imports even if they are explicitly listed in exposed-modules
4 participants