Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session and process are the same thing, but aren't, and this causes pain #799

Closed
deepfire opened this issue Aug 5, 2015 · 6 comments
Closed

Comments

@deepfire
Copy link
Contributor

deepfire commented Aug 5, 2015

Witness haskell-process-start:

    (haskell-session-set-process session process)
    (haskell-process-set-session process session)

..this says everything. The objects are the same thing, and the question is what to do about it.

I propose we cease this schizophrenia, recognize this fact and merge them into one single entity -- let's provisionally call it proc, for the lack of a better name.

@gracjan, what do you think?

@geraldus
Copy link
Contributor

geraldus commented Aug 5, 2015

I think it is good idea.

@gracjan
Copy link
Contributor

gracjan commented Aug 5, 2015 via email

@gracjan
Copy link
Contributor

gracjan commented Aug 7, 2015

@deepfire: Do you have a good plan how to unify session and process? That is a lot of code. Can you list tasks that would lead to the unification?

@deepfire
Copy link
Contributor Author

deepfire commented Aug 7, 2015

I don't except one vague idea that -- since session has a longer lifetime than process, the latter should be merged into the former.

This can be done in two steps:

  1. Trivial substitution -- maximum mechanical text transformation, so as not to break anything
  2. Perform sweeping simplifications

@deepfire
Copy link
Contributor Author

deepfire commented Aug 8, 2015

Progress made in #808.

@gracjan
Copy link
Contributor

gracjan commented Aug 12, 2016

In the light of intero I think we should skip all major overhauls in interactive mode. Intero itself is such an overhaul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants