Switch the configuration from Dahll to Yaml #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpickering
reviewed
Jun 15, 2019
| parseJSON (Object (Map.toList -> [(key, val)])) | ||
| | key == "cabal" = case val of | ||
| Object x | Just (String v) <- Map.lookup "component" x -> return $ Cabal $ Just $ T.unpack v | ||
| _ -> return $ Cabal Nothing |
There was a problem hiding this comment.
This is going to be confusing because it will accept cabal: garbage. Something to change in future.
|
Good start. I'll merge this in but needs to be modified before being released (imo). |
|
Also, all the documentation needs to be updated. |
|
Thanks - agreed - more testing would be good too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this patch is completely untested (other than it builds), since you didn't seem to have any Dahll test files sitting around. I went for a pretty simple encoding, so
cabal:orcabal: {component: lib}are sufficient. It probably doesn't produce fantastic error messages.