Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass filepath to cabal v2-repl when getting flags #123

Merged
merged 3 commits into from
Jan 25, 2020

Conversation

lukel97
Copy link
Contributor

@lukel97 lukel97 commented Jan 5, 2020

Instead of component. This lets Cabal figure out what component the module is in and should give more reliable flags for modules living outside of the specified component.

@lukel97
Copy link
Contributor Author

lukel97 commented Jan 5, 2020

Related to haskell/haskell-ide-engine#1526

@lukel97 lukel97 force-pushed the cabal-repl-wrapper-pass-filepath branch 5 times, most recently from 8404a26 to b529475 Compare January 5, 2020 16:58
src/HIE/Bios/Cradle.hs Outdated Show resolved Hide resolved
@mpickering
Copy link
Collaborator

This seems like a good idea but I haven't tested the patch at all and won't have time to in the foreseeable future.

@fendor fendor mentioned this pull request Jan 25, 2020
3 tasks
lukel97 and others added 3 commits January 25, 2020 16:58
Instead of component. This lets Cabal figure out what component the
module is in and should give more reliable flags for modules living
outside of the specified component.
@lukel97 lukel97 force-pushed the cabal-repl-wrapper-pass-filepath branch from 5bc5221 to 46e0832 Compare January 25, 2020 16:58
@fendor fendor merged commit c7057ad into haskell:master Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants