Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for implicit cradles #135

Merged
merged 3 commits into from
Jan 26, 2020
Merged

Add tests for implicit cradles #135

merged 3 commits into from
Jan 26, 2020

Conversation

lukel97
Copy link
Contributor

@lukel97 lukel97 commented Jan 25, 2020

No description provided.

fendor
fendor requested changes Jan 25, 2020
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra source files need to be added hie-bios.cabal
Also, Changelog file is not required, so it is not necessary to commit that-

@lukel97 lukel97 requested a review from fendor January 26, 2020 09:26
@lukel97 lukel97 force-pushed the implicit-cradle-tests branch 5 times, most recently from 85354b0 to ece5e8c Compare January 26, 2020 11:35
@lukel97 lukel97 force-pushed the implicit-cradle-tests branch 3 times, most recently from 791f0f3 to cffdb56 Compare January 26, 2020 11:57
@lukel97 lukel97 force-pushed the implicit-cradle-tests branch 2 times, most recently from b975cce to ccccecd Compare January 26, 2020 12:32
@fendor fendor merged commit c44a5f8 into haskell:master Jan 26, 2020
@fendor fendor mentioned this pull request Jan 28, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukel97 @fendor