Add a mechanism to prevent hie-bios from searching upwards #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukel97
commented
Jan 26, 2020
fendor
requested changes
Jan 26, 2020
Changes the logic of `findFileUpwards` to stop at any directories that contain the file `.hie-bios.stop`. This should be useful for testing different cradle setups.
|
I previously worked around this by physically copying the directory to be tested to a But being able to limit scope is a good thing, e.g. trying to work on checked-out ghcide submodule of hls, only. |
fendor
added
type: enhancement
|
Out of interest, what happens if the |
|
@fendor It uses the |
lukel97
added a commit
to lukel97/hie-bios
that referenced
this pull request
Jul 7, 2020
…askell#136)" This reverts commit dd181b8.
fendor
pushed a commit
that referenced
this pull request
Jul 7, 2020
)" This reverts commit dd181b8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the logic of
findFileUpwardsto stop at any directories that contain the file.hie-bios.stop. This should be useful for testing different cradle setups.