Fix parsing of spaces in targets ghci-scripts #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
issue162/parse-space-in-target
branch
from
da1e7ee
to
7caf542
Compare
fendor
force-pushed
the
issue162/parse-space-in-target
branch
from
7caf542
to
c5ca861
Compare
fendor
force-pushed
the
issue162/parse-space-in-target
branch
from
c5ca861
to
e4eb383
Compare
fendor
force-pushed
the
issue162/parse-space-in-target
branch
from
e4eb383
to
43366ee
Compare
jneira
approved these changes
Mar 17, 2020
fendor
commented
Mar 17, 2020
mpickering
reviewed
Mar 18, 2020
| $ concatMap (tail {- first element is ":add" which we want to remove -} | ||
| . words) | ||
| $ filter (":add" `isPrefixOf`) contents | ||
| let parseGhciLine = concatMap fst . filter (null . snd) . readP_to_S parser |
There was a problem hiding this comment.
Should it perhaps be an error if the parse fails?
There was a problem hiding this comment.
I dont think so, since an example ghci-script from stack looks like:
:add A B
:module + B
We only want to successfully parse the first line.
However, we could fail only for lines beginning with :add.
mpickering
reviewed
Mar 18, 2020
mpickering
reviewed
Mar 18, 2020
| value = many1 (satisfy (not . isSpace)) | ||
|
|
||
| anyToken :: ReadP Char | ||
| anyToken = satisfy $ const True |
There was a problem hiding this comment.
Pretty sure that not all tokens are valid here.
There was a problem hiding this comment.
True, only those that are valid in module names. But I dont think we want to validate these module names here and when attempting to load, we crash anyways.
But we can change it.
|
Thanks, left comments but an improvement anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #162