Clean up hie-bios wrapper scripts after they are used #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
reviewed
May 7, 2020
| where | ||
| setMode wrapper_fp = do | ||
| setFileMode wrapper_fp accessModes | ||
| _check <- readFile wrapper_fp |
There was a problem hiding this comment.
Should we just delete that?
There was a problem hiding this comment.
I think we could, I had a look at where it was introduced and it used to print out the cradle to stderr after writing it to the file. That was modified when we started using a proper executable on windows to get the arguments.
fendor
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.