Store dependencies in CradleError #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
requested changes
Jun 8, 2020
This allows you to attempt to rerun a failed cradle if any of the dependencies change. It is not a very precise measure of why a cradle failed but better than nothing.
fendor
force-pushed
the
wip/cradle-error-deps
branch
from
583c0cc
to
31b45f5
Compare
fendor
force-pushed
the
wip/cradle-error-deps
branch
2 times, most recently
from
87c41f7
to
81b54b6
Compare
fendor
force-pushed
the
wip/cradle-error-deps
branch
from
81b54b6
to
fdcc2af
Compare
fendor
reviewed
Jun 8, 2020
| @@ -183,6 +194,8 @@ test-suite bios-tests | |||
| extra, | |||
| tasty, | |||
| tasty-hunit, | |||
| tasty-expected-failure, | |||
| hspec-expectations, | |||
There was a problem hiding this comment.
error message isnt as nice yet as I hoped. We probably need to adapt the runner a bit.
Currently, the error message in a test-case failure looks like this (pretty formatted):
HUnitFailure
(Just
SrcLoc
{ srcLocPackage = "main"
, srcLocModule = "Main"
, srcLocFile = "tests/BiosTests.hs"
, srcLocStartLine = 150
, srcLocStartCol = 37
, srcLocEndLine = 150
, srcLocEndCol = 84
})
(Reason "Cradle loaded successfully")
fendor
reviewed
Jun 8, 2020
Comment on lines
+126
to
+128
| CradleFail err -> | ||
| pure $ CradleFail | ||
| (err { cradleErrorDependencies = cradleErrorDependencies err `union` deps }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to attempt to rerun a failed cradle if any of the
dependencies change. It is not a very precise measure of why a cradle
failed but better than nothing.
Situations where this helps:
hie.yamlSituations where it doesn't help: