Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Cradle utilizes #189

Merged
merged 1 commit into from
May 26, 2020
Merged

Export Cradle utilizes #189

merged 1 commit into from
May 26, 2020

Conversation

Avi-D-coder
Copy link
Contributor

@Avi-D-coder Avi-D-coder commented May 22, 2020 •
edited

Followup to #178.
closes: #165

This is needed for Avi-D-coder/implicit-hie-cradle.

I copied anything I did not see beaning used by other cradles besides the implicit one.

@jneira
Copy link
Member

jneira commented May 22, 2020 •
edited

... and it would close #165 😄
It is inevitable (well very convenient) if we want to create libraries over hie-bios.

@jneira jneira requested a review from fendor May 22, 2020 05:24
@Avi-D-coder
Copy link
Contributor Author

@mpickering @fendor Could you take a look at this

jneira
jneira approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and necessary if we want to write libs over hie-bios without duplicating code

@mpickering mpickering merged commit a852cff into haskell:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

@fendor fendor Awaiting requested review from fendor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose smart constructor(s) from Hie.Bios.Cradle to create cradles programatically
3 participants
@Avi-D-coder @jneira @mpickering