Improve filtering of rts arguments from stack and cabal cradles #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
extend-rts-filter
branch
3 times, most recently
from
228ea33
to
498bf97
Compare
rjmk
reviewed
Jun 11, 2020
fendor
force-pushed
the
extend-rts-filter
branch
from
498bf97
to
9dee145
Compare
rjmk
reviewed
Jun 11, 2020
fendor
force-pushed
the
extend-rts-filter
branch
3 times, most recently
from
e385b3b
to
4b50e00
Compare
fendor
force-pushed
the
extend-rts-filter
branch
from
4b50e00
to
7e879d0
Compare
Handles the case that the rts flags produced by the cradles are within a single string. Before we only allowed the rts flags to occur in the following form: > ["+RTS", "-H32m","-RTS"] and now we allow: > ["+RTS -H32m -RTS"] and filter the ComponentOptions appropriately.
fendor
force-pushed
the
extend-rts-filter
branch
from
7e879d0
to
5e2e1ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the case that the rts flags produced by the cradles are
within a single string.
Before we only allowed the rts flags to occur in the following form:
and now we allow:
and filter the ComponentOptions appropriately.