Make Cradle dependencies for stack and cabal more reasonable #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
requested review from
mpickering and
jneira
and removed request for
mpickering
lukel97
reviewed
Jul 1, 2020
| let relFp = makeRelative rootDir componentDir | ||
| cabalFiles' <- findCabalFiles componentDir | ||
| let cabalFiles = map (relFp </>) cabalFiles' | ||
| return $ map normalise $ cabalFiles ++ ["cabal.project", "cabal.project.local"] |
There was a problem hiding this comment.
Does findCabalFiles need to change into the rootDir here?
There was a problem hiding this comment.
I dont think so, findCabalFiles needs to look in the sub-directory of a cradle if there is one. E.g. fir hie-plugin-api, the relevant cabal file is in the sub directory. Then it returns cabal files relative to the component directory. Afterwards we need to make the dependencies relative to the root dir, otherwise our promise that dependencies are relative to the root dir cannot be upheld.
fendor
force-pushed
the
improve-cradle-deps
branch
2 times, most recently
from
bee60e4
to
84cef5b
Compare
fendor
force-pushed
the
improve-cradle-deps
branch
from
84cef5b
to
656b849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #203