GitHub actions improvements #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upload the sdist as an artifact too
lukel97
force-pushed
the
split-out-shellcheck-job
branch
from
29116b6
to
8496d94
Compare
It was slow and is now covered by GitHub actions CI, which can run these jobs in parallel
fendor
reviewed
Jul 1, 2020
lukel97
force-pushed
the
split-out-shellcheck-job
branch
from
b97c984
to
f70207e
Compare
lukel97
force-pushed
the
split-out-shellcheck-job
branch
from
f70207e
to
cb32087
Compare
|
Ugh windows build is doing something flaky. Good to merge |
|
Why is it flaky? Is it a good idea to replace something working with a flaky build? |
jneira
reviewed
Jul 2, 2020
| @@ -31,14 +30,30 @@ jobs: | |||
| path: ~/.cabal | |||
There was a problem hiding this comment.
does this path works for windows? The last build is not using cache but it doesn't save it afaics
There was a problem hiding this comment.
The path is working, I think it's this issue actions/cache#144
|
Merged in #267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.