A couple of fixes needed to use hie-core on Darcs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Batch files are limited by the cmd.exe arguments limit of 8191 characters, which can be exceeded by a project with a few hundred source files. Printing out the wrapper as a check is now skipped as it might be an exe.
They need to be recognised and passed in DynFlags rather than as source modules. Code copied from ghc as it's not exposed.
mpickering
reviewed
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Darcs is big enough that the ghc command-line is about 11K characters which blows the limit for
Windows batch files. We discussed this a bit in person at Munihac and decided this was the least
invasive solution.
Also needed to lift a bit more code from ghc's Main.hs to support recognising '.o' arguments coming
from C source code and passing them to the right place.