Add optional ghc-path field in bios cradles #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
reviewed
Aug 7, 2020
| Cradle | ||
| { cradleRootDir = wdir | ||
| , cradleOptsProg = CradleAction | ||
| { actionName = Types.Bios | ||
| , runCradle = biosAction wdir biosCall biosDepsCall | ||
| , runGhcCmd = runGhcCmdOnPath wdir | ||
| , runGhcCmd = \args -> readProcessWithCwd wdir (fromMaybe "ghc" mbGhc) args "" |
There was a problem hiding this comment.
Would it make sense to canonicalize the path if it is relative?
There was a problem hiding this comment.
Good question, I'm not sure. The path is only ever used in this call to readProcess, so I think it probably doesn't matter much.
fendor
requested changes
Aug 7, 2020
Co-authored-by: fendor <fendor@users.noreply.github.com>
|
Thanks for the quick review! Once I fix the test failures, I'm very keen on a minor release incorporating this change as it will allow us to start using ghcide in some parts of our Haskelll codebase at work. Thanks again! |
|
The travis tests fail because you need to add the test files to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215 to a simpler extent, in that the
with-ghcfield is of typeStringrather thanIO String.