Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIE_BIOS_ARG not passed to the dependencies program #235

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

pepeiborra
Copy link
Contributor

Follow up to #233 in order to fix #234

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fendor
Copy link
Collaborator

fendor commented Aug 12, 2020

I have no idea why the tests fail...

@fendor
Copy link
Collaborator

fendor commented Aug 12, 2020

The tests are broken on windows in general... So, unrelated to your changes.

EDIT:

simple-bios-shell:                             OK (0.58s)
      Finding Cradle for: C:\Users\runneradmin\AppData\Local\Temp\hie-bios-test-5922e46af396abb1\B.hs
      Loading Cradle: Just "C:\\Users\\runneradmin\\AppData\\Local\\Temp\\hie-bios-test-5922e46af396abb1\\hie.yaml"
      Get runtime GHC library directory                              (0.06s)
      Get runtime GHC version                                        (0.03s)
      Initialise Flags                                               (0.18s)
      Initial module load
      comp opts: ComponentOptions {componentOptions = [], componentRoot = "C:\\Users\\runneradmin\\AppData\\Local\\Temp\\hie-bios-test-5922e46af396abb1", componentDependencies = []} (0.24s)
      (1,2)                                                          (0.06s)
      (2,2)

The options are wrong here, too.

@pepeiborra
Copy link
Contributor Author

This is ready to merge (and release please)

@fendor fendor merged commit 1d9d5c3 into haskell:master Aug 26, 2020
@fendor
Copy link
Collaborator

fendor commented Aug 26, 2020

Release will be later this day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bios dependencies program is not passed at target as argument
2 participants