Run ghc for the wrapper in the temp directory to avoid .ghc-environment #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some versions of cabal write out .ghc-environment files which can then break ghc when run from the project folder. The required working directory is passed in CreateProcess parameters as changing directory first isn't thread-safe.
mpickering
reviewed
Sep 7, 2019
| callProcess "ghc" ["-o", wrapper_fp, wrapper_hs] | ||
| let ghc = (proc "ghc" ["-o", wrapper_fp, wrapper_hs]) | ||
| { cwd = Just (takeDirectory wrapper_hs) } | ||
| readCreateProcess ghc "" >>= putStr |
There was a problem hiding this comment.
Is this putStr for debugging?
There was a problem hiding this comment.
It's to replicate the previous behaviour of callProcess which just passed through stdout directly. There doesn't seem to be a callProcess equivalent if you need a custom CreateProcess value.
There was a problem hiding this comment.
You should use createProcess rather than readCreateProcess then? proc by default inherits the stdout handle.
There was a problem hiding this comment.
That would work, but then I'd have to copy and paste the bits of callProcess that throw an error if the command fails (or we decide we don't care about that).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.