Only take the last line of output in getRuntimeGhcX #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, do you need a minor release for that? |
|
I'll test it out on haskell/haskell-language-server#504 first and get back to you |
fendor
reviewed
Oct 17, 2020
Fixes cases on windows where stack's output looks like this: \n7-Zip 9.20 Copyright (c) 1999-2010 Igor Pavlov 2010-11-18\n\nProcessing archive: C:\\Users\\runneradmin\\AppData\\Local\\Programs\\stack\\x86_64-windows\\ghc-8.8.3.tar.xz\n\nExtracting ghc-8.8.3.tar\n\nEverything is Ok\n\nSize: 2555330560\nCompressed: 204702116\n8.8.3
lukel97
force-pushed
the
trim-stack-ghc-ver-output
branch
from
7ed0b52
to
cec139a
Compare
fendor
approved these changes
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cases on windows where stack's output looks like this: