Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HIE_BIOS_GHC #274

Closed
wants to merge 2 commits into from
Closed

Conversation

pepeiborra
Copy link
Contributor

Closes #270

@pepeiborra
Copy link
Contributor Author

This is ready for review

@jneira jneira requested a review from fendor December 28, 2020 10:53
@adamse
Copy link

adamse commented Dec 28, 2020

Looks like this also makes a nice solution for #253

@fendor
Copy link
Collaborator

fendor commented Dec 28, 2020

Ill see that I review it tomorrow.

So far the main changes are:

  • remove runGhcCmd from Cradle a
  • add componentRunGhcCmd for ComponentOptions
  • add HIE_BIOS_GHC output variable for cradle actions.
  • Adds some instances for CradleLoadResult

Did I catch most changes?

@fendor
Copy link
Collaborator

fendor commented Dec 29, 2020

I am worried componentRunGhcCmd breaks Haskell Language Server - wrapper.

Afaik, the flow is as follow:

  • Find hie.yaml
  • Use runGhcCmd to find the ghc version
  • Launch the correct HLS version

How would that work with componentRunGhcCmd?

  • Find hie.yaml
  • Find some component?
  • Use componentRunGhcCmd to find the ghc version
  • Launch the correct HLS version

@pepeiborra
Copy link
Contributor Author

How would that work with componentRunGhcCmd?

Presumably the wrapper is always invoked with an input file, right? So the flow would be

  • Find hie.yaml
  • Find the local cradle
  • Load the file with the cradle, resulting in some ComponentOptions
  • Use componentRunGhcCmd to find the ghc version
  • Launch the correct HLS version

@pepeiborra
Copy link
Contributor Author

I assumed wrong - the wrapper is not invoked with an input file. I don't know how to solve this, it seems that tying the ghc libdir to a specific component is not a good idea after all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: faster Bios protocol
3 participants