Pass dynamic flag for dynamic GHC #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Acutally, I think it would be a good idea to add documentation about the |
Closed
berberman
added a commit
to berberman/hie-bios
that referenced
this pull request
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need reflect the dynamic flag to default cradle and direct cradle, otherwise users are required to write an explicit hie.yaml to pass the dynamic flag. We don't want to pass the flag to stack cradle or cabal cradle, since I think we can assume that users have already configured the dynamic flag manually in their build tools.
By adding this, most of ghcide's tests can pass on Arch Linux.