Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Cradle Logic into smaller components #29

Merged
merged 1 commit into from
Sep 8, 2019

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Sep 8, 2019

API Changes:

-- | Given root/foo/bar.hs, return root/hie.yaml, or wherever the yaml file was found
findCradle :: FilePath -> IO (Maybe FilePath)

-- | Given root/hie.yaml load the Cradle
loadCradle :: FilePath -> IO Cradle

-- | Given root/foo/bar.hs, load an implicit cradle
loadImplicitCradle :: FilePath -> IO Cradle

Currently assumes, #26 will be merged, but can be rebased if necessary.
closes #9 afaik.
cc @ndmitchell

@fendor fendor changed the title Split Cradle Loigic into smaller components Split Cradle Logic into smaller components Sep 8, 2019
@fendor fendor force-pushed the cradle-split branch 3 times, most recently from 9ba0836 to b40e328 Compare September 8, 2019 13:24
Split up the cradle logic into findCradle and loadCradle.
@fendor fendor merged commit eab0e4a into haskell:master Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evolving the API
1 participant