Drop hspec-expectations asserts as they don't get rendered properly by tasty #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
changed the title
Remove hspec-expectations dependency since it doesn't get rendered properly and makes failing test-cases harder to read.
fendor
force-pushed
the
enhance/drop-hspec-expectations
branch
from
bf4b93c
to
4ffee0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced
hspec-expectationsbecause I prefer the asserts over the infix operators fromtasty-hunitand the libraries feels more batteries-included.Tasty doesn't render errors from those assert properly, which makes it way harder to read once a test fails. Thus, drop them.