Move logging from hslogger to co-log #347
Conversation
|
This is what the output from HLS looks like after incorporating this change. You can see that the hie-bios logs now get formatted like everything else. Before: After: |
|
cc @eddiemundo |
|
Thank you for bringing co-log to hie-bios! |
| import Data.Version (showVersion) | ||
| import Data.Text.Prettyprint.Doc |
There was a problem hiding this comment.
GitHub Actions scream a bunch of deprecation warnings here. Can we do something about that? I remember, there was an issue with my PR haskell/haskell-language-server#2352
There was a problem hiding this comment.
Yeah, I'm not sure what the best approach is. Pepe really wants to keep compatibility with old prettyprinter versions. That gives us two options: 1) use the deprecated import, 2) use CPP. I hate 1 less but I'm happy to take the other bad option also.
There was a problem hiding this comment.
Eh, for now, just leave it be. Eventually we can just drop it, probably.
This lines up with the way that logging is being done in `haskell-language-server` and `lsp`. At the moment `hie-bios` is the only reason HLS has a `hslogger` dependency, and it means that the logs from `hie-bios` are inconsistent with those from the rest of the subsystems.
|
Fixed the tests. Somehow I just didn't realise they existed 😅 I generally stopped them from issuing a step every log line, which seemed excessive, and instead just put in a couple of explicit steps. CI is green. |
This lines up with the way that logging is being done in
haskell-language-serverandlsp.At the moment
hie-biosis the only reason HLS has ahsloggerdependency, and it means that the logs from
hie-biosare inconsistentwith those from the rest of the subsystems.